Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shim should be sorted away #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Shim should be sorted away #1

wants to merge 3 commits into from

Conversation

thom4parisot
Copy link

It would be better to encourage people to use es5shim instead.

Or providing the shins as a plugin.
But something optional.

@thom4parisot
Copy link
Author

Plus, I removed the onload. You can provide an additional registerEvents method who would do that for lazy people.

Otherwise this will be fine enough:

[].slice.call(document.querySelectorAll('table.sortable')).forEach(sorttable.makeSortable)

Or with a new init doing the job

sorttable.makeSortable(document.querySelectorAll('table.sortable'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thom4parisot